Open
Conversation
This allows wrapping repository operations in a transaction so that they can be atomically committed to the database or rolled back in case of error.
Contributor
Author
|
Seems like SQLite in-memory doesn't have normal transaction support, based on the failing "update and rollback" test. |
Contributor
Author
|
I would prefer to keep this code out of the library, as it may promote some non-ideal practices, such as the modifying of multiple aggregates in a single transaction, which is frowned upon by DDD purists. Perhaps we should just document the mechanism and projects can implement it internally if desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an implementation of the Unit of Work pattern so that multiple repository operations can be wrapped into a transaction and either committed or rolled back together.
Yes, EF Core DbContext already acts as a Unit of Work pattern implementation. You're welcome to use EF directly in your application but you will likely have less control over how your entities are populated, which may make it difficult to follow DDD patterns such as Aggregate.
You can register the EF Core implementation with your dependency injection like this:
then use it in your code by injecting into the consuming class:
What type of PR is this? (check all applicable)
Related Tickets & Documents
none
Changes Made
See above
Quality Checklist
Additional Notes
Open for discussion as to the name of the interface and class.